Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Changes between css tutorial and extend_your_application #1188

Open
MichaelClerx opened this issue Dec 12, 2017 · 2 comments · May be fixed by #1256
Open

CSS Changes between css tutorial and extend_your_application #1188

MichaelClerx opened this issue Dec 12, 2017 · 2 comments · May be fixed by #1256
Labels
help wanted newcomer friendly status: accepted

Comments

@MichaelClerx
Copy link

MichaelClerx commented Dec 12, 2017 •
edited

At the end of https://tutorial.djangogirls.org/en/css/ there is an image showing the publication date aligned left

By https://tutorial.djangogirls.org/en/extend_your_application/ it has become right-aligned, and as far as I can see there's no bit in the tutorial telling you to make this change.
The next tutorial (https://tutorial.djangogirls.org/en/django_forms/) also has a right-aligned publication date (including the edit button)
@ekohl
Copy link
Collaborator

ekohl commented Jan 19, 2018

You're right. We could really use a round of fresh screenshots.

@ekohl ekohl mentioned this issue Jan 19, 2018
Open
realslimshanky pushed a commit to realslimshanky/tutorial that referenced this issue Apr 15, 2018
Fixes DjangoGirls#1188
ab101a9 
Issue 'CSS Changes between `css` tutorial and `extend_your_application`'
has been fixes by updating the screenshots. Updated screenshots show
publication date/time on the left had side just as intended.
@realslimshanky realslimshanky linked a pull request Apr 15, 2018 that will close this issue
Open
realslimshanky pushed a commit to realslimshanky/tutorial that referenced this issue Apr 15, 2018
Fixes DjangoGirls#1188
da6de32 
Issue 'CSS Changes between `css` tutorial and `extend_your_application`'
has been fixes by updating the screenshots. Updated screenshots show
publication date/time on the left had side just as intended.
@realslimshanky
Copy link

I've raised a PR to fix this issue. Please review. cc: @MichaelClerx @ekohl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted newcomer friendly status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update extend your application screenshots realslimshanky/tutorial
3 participants
@ekohl @MichaelClerx @realslimshanky