Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rendered result (HTML files) downloadable #1715

Open
das-g opened this issue Apr 22, 2021 · 1 comment
Open

Make rendered result (HTML files) downloadable #1715

das-g opened this issue Apr 22, 2021 · 1 comment

Comments

@das-g
Copy link
Member

das-g commented Apr 22, 2021

Issue description

Make the HTML files generated by the GitHub action downloadable. This would have several use-cases:

  • check that workflows that do not trigger a deployment (for branches other than master) produced the expected result
  • use the tutorial offline (see e.g. this question in our Gitter chatroom)

I guess this can be achieved by declaring result directory to be an artifact? (Here's GitHub's documentation on how to download GitHub Actions workflow artifacts.)

Language

all

Operating system

n/a

@ekohl
Copy link
Collaborator

ekohl commented Apr 22, 2021

check that workflows that do not trigger a deployment (for branches other than master) produced the expected result

I guess that makes sense can help with reviewing PRs. I would probably not generate them on pushes to master though since we already update gh-pages.

use the tutorial offline (see e.g. this question in our Gitter chatroom)

For that you can already download the gh-pages branch: https://github.com/DjangoGirls/tutorial/archive/refs/heads/gh-pages.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants