Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Viewport Scaling Visibility #26

Closed
blast-harbour opened this issue Sep 30, 2023 · 7 comments
Closed

[Feature Request]: Viewport Scaling Visibility #26

blast-harbour opened this issue Sep 30, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@blast-harbour
Copy link

blast-harbour commented Sep 30, 2023

Feature description

My project uses a 4k base resolution to make use of high resolution UI assets. as a result, the lines drawn by debug draw 3d become too thin to see often.
image

Implementation Ideas

Maybe a way to set line thickness would be helpful?

@blast-harbour blast-harbour added the enhancement New feature or request label Sep 30, 2023
@DmitriySalnikov
Copy link
Owner

DmitriySalnikov commented Sep 30, 2023

I think this relates to #3


Is the editor interface also very thin in 4K? (when selecting 3d nodes, for example)

@kitbdev
Copy link

kitbdev commented Sep 30, 2023

Using anti-aliasing on the lines should fix this and would allow for the lines to stay the same size. For reference I'm thinking of this

@DmitriySalnikov
Copy link
Owner

In this addon, I just draw wireframes that the engine displays with a thickness of 1 pixel at any resolutions. So I'm not sure if anti-aliasing will help.


It looks a little better with anti-aliasing, but I can't check it in 4K or even 1440p.

No AA:
image

MSAA 8x:
image

TAA:
image

@kitbdev
Copy link

kitbdev commented Oct 15, 2023

Possibly related: godotengine/godot#37016
Is this in Vulkan or the Compatibility OpenGL renderer?
I'm also curious what the 3D scene view looks like at 4k, does the grid there have the same issues?

@DmitriySalnikov
Copy link
Owner

DmitriySalnikov commented Nov 16, 2023

Does this version look better (in terms of visibility)? Link to my personal server (Chromium only)
In this demo, all meshes are replaced with volumetric ones with a thickness of 0.1.

Unlike the usual wireframe lines, which are always rendered as 1px, these meshes change their size depending on the distance.
image

There are still distortion issues right now (with certain transformations), and I don't know if I can fix it.

And I have not decided how to change the API so that it is possible to switch to regular or volumetric models. Add another parameter to all draw_* methods? Or call another method before draw_*, for example set_line_thickness?

@DmitriySalnikov
Copy link
Owner

godot.windows.editor.dev.x86_64.mono_WkVTn0jFnz.mp4

@DmitriySalnikov
Copy link
Owner

Fixed in f96700b

@skooter500 skooter500 mentioned this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants