feat(kitmw): fix race condition

DoNewsCode · Mar 10, 2021 · 27e5f4c · 27e5f4c
1 parent aad54e7
commit 27e5f4c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/kitmw/async.go b/kitmw/async.go
@@ -28,6 +28,7 @@ func MakeAsyncMiddleware(logger log.Logger, concurrency int) endpoint.Middleware
 				defer func() {
 					limit <- struct{}{}
 				}()
+				var err error
 				ctx := opentracing.ContextWithSpan(context.Background(), span)
 				_, err = next(ctx, request)
 				if err != nil {

diff --git a/kitmw/async_test.go b/kitmw/async_test.go
@@ -18,7 +18,7 @@ func TestMakeAsyncMiddleware(t *testing.T) {
 	m := MakeAsyncMiddleware(log.NewNopLogger(), 5)
 	f := m(func(ctx context.Context, request interface{}) (response interface{}, err error) {
 		c.Inc()
-		assert.Less(t, c.Load(), 5)
+		assert.Less(t, int(c.Load()), 5)
 		time.Sleep(time.Duration(rand.Float64()) * time.Second)
 		c.Dec()
 		return nil, nil