fix: config.Duration Unmarshal with koanf (#114) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 76.06% 75.97% -0.09%
==========================================
Files 81 81
Lines 3025 3047 +22
==========================================
+ Hits 2301 2315 +14
- Misses 541 544 +3
- Partials 183 188 +5
Continue to review full report at Codecov.
|
Reasno
reviewed
Mar 30, 2021
| f reflect.Type, | ||
| t reflect.Type, | ||
| data interface{}) (interface{}, error) { | ||
| if t != reflect.TypeOf(Duration{}) { |
There was a problem hiding this comment.
we should support std library time.Duration in adition to config.Duration.
There was a problem hiding this comment.
ie. reflect.TypeOf(time.Duration{}) should work out of box.
Reasno
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.