feat: add mysql connection metrics #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 76.38% 76.77% +0.38%
==========================================
Files 82 83 +1
Lines 3083 3143 +60
==========================================
+ Hits 2355 2413 +58
- Misses 540 542 +2
Partials 188 188
Continue to review full report at Codecov.
|
Reasno
changed the title
Reasno
changed the title
* fix(otgorm): metrics missing labels * fix: add with value, extend waiting time
Reasno
changed the title
|
redis connection metrics can be added in another PR. #127 |
GGXXLL
reviewed
Apr 27, 2021
observability/observability.go
Outdated
| @@ -75,7 +45,7 @@ type configOut struct { | |||
| Config []config.ExportedConfig `group:"config,flatten"` | |||
| } | |||
|
|
|||
| func provideConfig() configOut { | |||
| func exportConfig() configOut { | |||
There was a problem hiding this comment.
Other package export config func name is provideConfig, unified? Which one should we use?
There was a problem hiding this comment.
provideConfig. As this is a private function, we can always change it at any point.
GGXXLL
previously approved these changes
Apr 27, 2021
GGXXLL
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.