Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kafka metrics #130

Merged
merged 12 commits into from
May 19, 2021
Merged

feat: Add kafka metrics #130

merged 12 commits into from
May 19, 2021

Conversation

GGXXLL
Copy link
Contributor

@GGXXLL GGXXLL commented Apr 28, 2021

WIP

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #130 (08bea71) into master (f89361d) will increase coverage by 3.04%.
The diff coverage is 99.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   77.12%   80.17%   +3.04%     
==========================================
  Files          84       87       +3     
  Lines        3205     3698     +493     
==========================================
+ Hits         2472     2965     +493     
+ Misses        546      545       -1     
- Partials      187      188       +1     
Impacted Files Coverage Δ
otgorm/dependency.go 88.13% <ø> (ø)
otredis/provider.go 77.90% <ø> (ø)
otkafka/module.go 92.85% <92.85%> (ø)
otkafka/writer_metrics.go 94.87% <94.87%> (ø)
observability/metrics.go 100.00% <100.00%> (ø)
observability/observability.go 100.00% <100.00%> (ø)
otkafka/dependency.go 89.58% <100.00%> (+1.77%) ⬆️
otkafka/reader_metrics.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89361d...08bea71. Read the comment docs.

@GGXXLL GGXXLL marked this pull request as ready for review May 14, 2021 07:47
@Reasno Reasno merged commit 6bae6a2 into DoNewsCode:master May 19, 2021
@GGXXLL GGXXLL deleted the kafka-metrics branch May 25, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants