feat: cluster address in env (close #131) #133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 77.10% 77.25% +0.14%
==========================================
Files 84 84
Lines 3219 3205 -14
==========================================
- Hits 2482 2476 -6
+ Misses 551 543 -8
Partials 186 186
Continue to review full report at Codecov.
|
GGXXLL
requested review from
Reasno and
lingwei0604
and removed request for
Reasno
otkafka/example_test.go
Outdated
| log: | ||
| level: none | ||
| kafka: | ||
| reader: | ||
| default: | ||
| brokers: | ||
| - ` + os.Getenv("KAFKA_ADDR") + ` | ||
| ` + brokersStr + ` |
There was a problem hiding this comment.
Probably should escape brokerStr in some way. As an example, what if brokerStr contains a #？
The current version has the same problem.
There was a problem hiding this comment.
The purpose was to intentionally skip the test if env is mot set. （So that the test passes on any environment）
Ok, I understand. some question:
I think there should be only one place to read env. It shouldn't be read everywhere, So I added these global variables.
If possible, I can also add other non multiple envs. What do you think of this code?
// Default multiple addresses from env
var (
EnvDefaultElasticsearchAddrs = getDefaultAddrsFromEnv("ELASTICSEARCH_ADDR", "http://127.0.0.1:9200")
EnvDefaultEtcdAddrs = getDefaultAddrsFromEnv("ETCD_ADDR", "127.0.0.1:2379")
EnvDefaultKafkaAddrs = getDefaultAddrsFromEnv("KAFKA_ADDR", "127.0.0.1:9092")
EnvDefaultRedisAddrs = getDefaultAddrsFromEnv("REDIS_ADDR", "127.0.0.1:6379")
)
No description provided.