Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename package remote to package etcd #175

Merged
merged 4 commits into from
Aug 6, 2021
Merged

refactor: rename package remote to package etcd #175

merged 4 commits into from
Aug 6, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Aug 6, 2021

ETCD is only one of the remote config implementations. It should not be called package remote.

Also core should not import stuff from etcd. It unnecessarily bloats build size.

@Reasno Reasno changed the title refactor: etcd != remote. refactor: rename package remote to package etcd Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #175 (2c198be) into master (7d7f997) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   80.23%   80.41%   +0.18%     
==========================================
  Files          91       91              
  Lines        3273     3273              
==========================================
+ Hits         2626     2632       +6     
+ Misses        471      466       -5     
+ Partials      176      175       -1     
Impacted Files Coverage Δ
c.go 76.55% <ø> (+1.04%) ⬆️
config/remote/etcd/etcd.go 86.20% <100.00%> (ø)
config/watcher/file.go 62.79% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7f997...2c198be. Read the comment docs.

@Reasno Reasno requested a review from GGXXLL August 6, 2021 07:01
GGXXLL
GGXXLL previously approved these changes Aug 6, 2021
@Reasno Reasno requested a review from GGXXLL August 6, 2021 07:49
@Reasno Reasno merged commit 2a18092 into master Aug 6, 2021
@Reasno Reasno deleted the remote branch August 6, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants