Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): shutdown the modules in the reversed order of registr… #187

Merged
merged 7 commits into from
Aug 31, 2021
Merged

fix(container): shutdown the modules in the reversed order of registr… #187

merged 7 commits into from
Aug 31, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Aug 31, 2021

…ation

@codecov
Copy link

codecov bot commented Aug 31, 2021 •
edited
Loading

Codecov Report

Merging #187 (1cc90a5) into master (baa2923) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   81.12%   81.33%   +0.21%     
==========================================
  Files          83       83              
  Lines        3158     3151       -7     
==========================================
+ Hits         2562     2563       +1     
+ Misses        440      433       -7     
+ Partials      156      155       -1
Impacted Files Coverage Δ
container/container.go 70.00% <100.00%> (+29.25%) ⬆️
config/remote/etcd/etcd.go 79.31% <0.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa2923...1cc90a5. Read the comment docs.

Reasno and others added 5 commits August 31, 2021 16:58
@Reasno
fix(container): shutdown the modules in the reversed order of registr…
935f1d1 
…ation
@GGXXLL @Reasno
feat(clihttp): limit max length a client can read from body (#186)
caff650 
* feat: limit the length when read body

* fix: WithResponseLogThreshold error and add test case
@Reasno @GGXXLL
refactor(container): remove ifilter dependency. (#183)
fb34e62 
* refactor: change how DI and container works

* docs: clarify words

* test: test the cleanup function is executed

* test: cover current behavior

* refactor: change how DI and container works

* docs: clarify words

* test: test the cleanup function is executed

* test: cover current behavior

Co-authored-by: Trock <35254251+GGXXLL@users.noreply.github.com>
@Reasno
feat: make metrics struct type safe (#185)
31bebd8 
* feat: Use type safe metrics struct

* doc: add comment

* Update doc.go

* refactor: use point receivers

* test: fix tests

* test: fix tests
@Reasno
fix(container): test
9d26ec7
@Reasno Reasno requested a review from GGXXLL August 31, 2021 09:07
@Reasno Reasno linked an issue Aug 31, 2021 that may be closed by this pull request
Distinct closers from various sources #182
Closed
@Reasno Reasno merged commit e2be4b3 into master Aug 31, 2021
@Reasno Reasno deleted the container branch August 31, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GGXXLL GGXXLL GGXXLL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinct closers from various sources
2 participants
@Reasno @GGXXLL