refactor: remove DIContainer abstraction #196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes core tightly coupled to uber/dig. While this is counter-intuitive, the previous abstraction was very leaky. Most components implicitly depend on uber/dig specific features, such as
dig.In
,dig.Out
andoptional:"true"
tags.The rationale of this PR is: good abstraction > no abstraction > bad/leacky abstration.
After this change, the core and components are free to use uber/dig's advanced features. I expect this will make developer UX much better.