Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve): signal group couldn't be canceled #208

Merged
merged 2 commits into from
Oct 21, 2021
Merged

fix(serve): signal group couldn't be canceled #208

merged 2 commits into from
Oct 21, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Oct 21, 2021

No description provided.

@Reasno Reasno requested a review from GGXXLL October 21, 2021 09:28
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #208 (38178a8) into master (e72a19d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   82.17%   82.13%   -0.05%     
==========================================
  Files          90       90              
  Lines        3451     3453       +2     
==========================================
  Hits         2836     2836              
- Misses        460      461       +1     
- Partials      155      156       +1     
Impacted Files Coverage Δ
serve.go 90.51% <100.00%> (+0.16%) ⬆️
config/watcher/file.go 58.13% <0.00%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72a19d...38178a8. Read the comment docs.

@Reasno Reasno merged commit 1dc6157 into master Oct 21, 2021
@Reasno Reasno deleted the fix/signal branch November 16, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants