Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid extra logger wraps #232

Merged
merged 3 commits into from
Jan 19, 2022
Merged

fix: avoid extra logger wraps #232

merged 3 commits into from
Jan 19, 2022

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Jan 19, 2022

the extra wrap hinders the correctness of runtime.Caller() stack level.

@Reasno Reasno requested a review from GGXXLL January 19, 2022 09:57
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #232 (be45e0d) into master (99d0912) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   83.61%   83.50%   -0.11%     
==========================================
  Files         102      102              
  Lines        3795     3796       +1     
==========================================
- Hits         3173     3170       -3     
- Misses        459      461       +2     
- Partials      163      165       +2     
Impacted Files Coverage Δ
c.go 77.57% <100.00%> (+0.13%) ⬆️
logging/log.go 42.25% <100.00%> (ø)
config/remote/etcd/etcd.go 84.84% <0.00%> (-6.07%) ⬇️
config/watcher/file.go 62.79% <0.00%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d0912...be45e0d. Read the comment docs.

@Reasno Reasno merged commit b1f094d into master Jan 19, 2022
@Reasno Reasno deleted the c branch January 19, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants