Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(factory): on reload, close the connection right away. #235

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Jan 20, 2022

graceful shutdown logic should be implemented in the close function, not in the factory.

graceful shutdown logic should be implemented in the close function, not in the factory.
@Reasno Reasno requested a review from GGXXLL January 20, 2022 10:13
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #235 (76621dd) into master (b1f094d) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   83.45%   83.46%           
=======================================
  Files         102      102           
  Lines        3796     3797    +1     
=======================================
+ Hits         3168     3169    +1     
+ Misses        462      461    -1     
- Partials      166      167    +1     
Impacted Files Coverage Δ
c.go 77.45% <73.33%> (-0.12%) ⬇️
di/factory.go 85.71% <100.00%> (-2.05%) ⬇️
config/watcher/file.go 62.79% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf7ad9...76621dd. Read the comment docs.

@GGXXLL GGXXLL merged commit eefb5df into master Jan 20, 2022
@Reasno Reasno deleted the di branch January 21, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants