Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otgorm): hooks #236

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix(otgorm): hooks #236

merged 2 commits into from
Feb 9, 2022

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Feb 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #236 (451bd1c) into master (0c0ae20) will increase coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   83.40%   83.43%   +0.02%     
==========================================
  Files         102      102              
  Lines        3797     3803       +6     
==========================================
+ Hits         3167     3173       +6     
  Misses        462      462              
  Partials      168      168              
Impacted Files Coverage Δ
otgorm/otgorm.go 80.00% <60.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0ae20...451bd1c. Read the comment docs.

@Reasno Reasno merged commit 1afb3d7 into master Feb 9, 2022
GGXXLL pushed a commit that referenced this pull request Feb 9, 2022
* fix(otgorm): hooks

* fix: remove debug prints

(cherry picked from commit 1afb3d7)
@Reasno Reasno deleted the otgorm branch March 17, 2022 08:10
GGXXLL added a commit that referenced this pull request May 19, 2022
* fix(factory): on reload, close the connection right away.

graceful shutdown logic should be implemented in the close function, not in the factory.

* fix(cron): test flakes

* feat: add eventv2

* wip: prototyping generics api

* wip: prototyping generics api

* wip: prototyping generics api

* feat: ctxmeta support generic

* fix: asyncContext.Value interface to any

* wip: generics

* wip: add once to event

* refactor: remove text package

* feat: interface{} to any

* refactor: remove deprecated cron

* test: workflow go-version 1.18beta2

* test: setup-go stable false

* test: fix workflow go-version

* doc: add listener comment

* feat: simplify run group

* fix: remove deprecatedcron test

* fix: missing StatusChanged

* fix: some test

* feat: simplify run group

* fix: some import style

* fix: remove config module dispatcher

* fix(otgorm): hooks (#236)

* fix(otgorm): hooks

* fix: remove debug prints

(cherry picked from commit 1afb3d7)

* refactor(control): add pool

* fix(pool): data race

* fix(pool): data race

* fix(pool): go vet "call to (*T).Fatalf from a non-test goroutine"

* refactor: change leader election semantics. (#238)

* refactor: change leader election semantics.

Now leader election campaign will not return when the node beomes leader, instead it will block until the leader election session exists, updating status proactively. This change will make leader election status more accurate.

* fix(leader): mock driver for test

* fix: return if renew fails

* test: increase test duration

* docs: add jetbrains thanks

* fix(cron): example flakes

* fix(leader): TestElection block test

* fix(leader): missing dispatch when leader status on

* fix(leader): test data race

* fix(leader): test key conflict

* test(ots3): test container of minio

* feat: add a simple way to ensure cron jobs to run at least once for each schedule.

* doc: add comment

* fix(leaderredis): data race

Co-authored-by: Trock <g_trock@163.com>

* fix: server.go merge conflict

* feat(test): upgrade github actions

* fix: otredis TestModule_ProvideCommand

* fix: workflow lint add setup-go

* fix: workflow lint add setup-go

* fix: pool.Run need start before call Go method when use async mode.

* feat: add pool.Counter to observe the status of pool.

Co-authored-by: Trock <g_trock@163.com>
Co-authored-by: Trock <35254251+GGXXLL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants