Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a configuration entry to disable servers. #93

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Mar 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #93 (4e1838b) into master (2932742) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   75.82%   75.93%   +0.10%     
==========================================
  Files          74       74              
  Lines        2850     2863      +13     
==========================================
+ Hits         2161     2174      +13     
  Misses        516      516              
  Partials      173      173              
Impacted Files Coverage Δ
container/container.go 46.66% <ø> (ø)
default_config.go 86.66% <100.00%> (+1.66%) ⬆️
serve.go 87.64% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2932742...4e1838b. Read the comment docs.

@Reasno Reasno requested a review from lingwei0604 March 16, 2021 05:25
Copy link
Member

@lingwei0604 lingwei0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, That's great.

@Reasno Reasno merged commit 519b601 into master Mar 16, 2021
@Reasno Reasno deleted the allow_disable_server branch March 16, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants