feat: add CronLogAdapter #88 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 75.93% 75.95% +0.02%
==========================================
Files 74 75 +1
Lines 2863 2866 +3
==========================================
+ Hits 2174 2177 +3
Misses 516 516
Partials 173 173
Continue to review full report at Codecov.
|
Reasno
reviewed
Mar 17, 2021
otcron/log.go
Outdated
|
|
||
| // Error implements cron.Logger | ||
| func (r CronLogAdapter) Error(err error, msg string, keysAndValues ...interface{}) { | ||
| _ = level.Error(r.Logging).Log("msg", msg, "error", err, keysAndValues) |
Reasno
requested changes
Mar 17, 2021
otcron/log.go
Outdated
|
|
||
| // Info implements cron.Logger | ||
| func (r CronLogAdapter) Info(msg string, keysAndValues ...interface{}) { | ||
| _ = level.Info(r.Logging).Log("msg", msg, keysAndValues) |
Reasno
reviewed
Mar 17, 2021
otcron/log.go
Outdated
| @@ -0,0 +1,21 @@ | |||
| package otcron | |||
There was a problem hiding this comment.
这个换个名字吧，ot是opentracing的意思，这个和tracing没关系。。
lingwei0604
reviewed
Mar 17, 2021
cronopts/log.go
Outdated
| } | ||
|
|
||
| // Info implements cron.Logger | ||
| func (r CronLogAdapter) Info(msg string, keysAndValues ...interface{}) { |
Reasno
previously approved these changes
Mar 17, 2021
lingwei0604
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.