Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pretty sagas config #116

Merged
merged 2 commits into from
Mar 30, 2021
Merged

refactor: pretty sagas config #116

merged 2 commits into from
Mar 30, 2021

Conversation

GGXXLL
Copy link
Contributor

@GGXXLL GGXXLL commented Mar 30, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #116 (74c9826) into master (2b3cb54) will decrease coverage by 0.06%.
The diff coverage is 83.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   76.02%   75.96%   -0.07%     
==========================================
  Files          79       81       +2     
  Lines        3016     3025       +9     
==========================================
+ Hits         2293     2298       +5     
- Misses        540      544       +4     
  Partials      183      183              
Impacted Files Coverage Δ
leader/dependency.go 88.37% <ø> (ø)
observability/observability.go 93.75% <0.00%> (ø)
queue/dependency.go 82.55% <ø> (ø)
dtx/sagas/dependency.go 83.87% <71.42%> (-1.85%) ⬇️
dtx/sagas/mysqlstore/config.go 77.77% <77.77%> (ø)
dtx/sagas/config.go 86.66% <86.66%> (ø)
config/time.go 71.42% <100.00%> (+1.42%) ⬆️
dtx/sagas/mysqlstore/dependency.go 62.96% <100.00%> (-7.63%) ⬇️
otetcd/dependency.go 92.59% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3cb54...74c9826. Read the comment docs.

@GGXXLL GGXXLL requested a review from Reasno March 30, 2021 06:25
@Reasno Reasno merged commit 21d1e79 into DoNewsCode:master Mar 30, 2021
@GGXXLL GGXXLL deleted the sagas-config branch March 30, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants