Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when closing the Dockstation window and reopening (macOS) #109

Closed
GasimGasimzada opened this issue Feb 25, 2018 · 8 comments
Closed

Comments

@GasimGasimzada
Copy link

  • macOS version: 10.13.3

  • Dockstation version: v1.3.0

    Uncaught Exception:
    Error: Object has been destroyed
    at App. (/Applications/DockStation.app/Contents/Resources/app.asar/webpack:/app/main.prod.js:1:1)
    at emitTwo (events.js:106:13)
    at App.emit (events.js:194:7)

I believe the error is there because macOS has window close an application close as separate functions in Electron.

@igor-lemon
Copy link
Member

Hi @GasimGasimzada

How often can you reproduce the error, per each close app event?

@GasimGasimzada
Copy link
Author

Sorry, I did not see your response a month ago. The error is still there. 100% of the time.

@igor-lemon
Copy link
Member

Hi. Did you update up to v1.4?

@GasimGasimzada
Copy link
Author

Yes, I just did and the error is still there. When I close the window, the app stays open; and when I try to open it, the window does not get created and I get an error.

@igor-lemon
Copy link
Member

Hm. It's very very strange. We checked this on the 3 different macs...
What is your OS version?
Also, can you record your screen when error throws? It can help us.

@igor-lemon
Copy link
Member

Fixed.

@GasimGasimzada
Copy link
Author

Thank you! Closing the window no reopens it properly. However, now CTRL+W is not closing the window. Is that the intended behavior?

@igor-lemon
Copy link
Member

The closing window via CMD+W was a mistake because the app has only 1 window and you should have only 2 options - Minimize (CMD + M) or Quit (CMD +Q) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants