Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newOffer not called sometimes #269

Open
Baterka opened this issue Mar 11, 2018 · 9 comments
Open

newOffer not called sometimes #269

Baterka opened this issue Mar 11, 2018 · 9 comments

Comments

@Baterka
Copy link

Baterka commented Mar 11, 2018

newOffer event is not called sometimes... Even after restart of bot, event is still not fired.
After I send second offer, newOffer triggers for both trades

@Baterka
Copy link
Author

Baterka commented Mar 16, 2018

Not fired if i send 2 offers at the same time. Called only for one offer. Second offer calling newOffer after sentOfferChanged or recievedOfferChanged triggers. Its seems like bug

@rover5056
Copy link

I found this question too.
When send 2 offers , the received bot will only fired newOffer once.
@Baterka How do you solute this bug? THX~

@Baterka
Copy link
Author

Baterka commented Sep 3, 2018

I not solved it... I think we need more reserach from @DoctorMcKay

@raccoondays
Copy link

I have gotten the same issue. I have been able to get only one trade through in the past 3 days on a bot that worked fine before, using the above method. Haven't been able to get any trades through on a new bot with a different account. I have tried manually setting the polling interval but it did nothing.

@Baterka
Copy link
Author

Baterka commented Oct 1, 2018

@atomic-addison Its bug... Ignored by @DoctorMcKay

@Golden00
Copy link

Bump doesn't fire at all now

@Golden00
Copy link

The source i'm using:
manager.on('newOffer', function(offer) { console.log("New offer #" + offer.id + " from " + offer.partner.getSteam3RenderedID()); offer.accept(function(err, status) { if (err) { console.log("Unable to accept offer: " + err.message); } else { console.log("Offer accepted: " + status); if (status == "pending") { community.acceptConfirmationForObject(config.identitySecret, offer.id, function(err) { if (err) { console.log("Can't confirm trade offer: " + err.message); } else { console.log("Trade offer " + offer.id + " confirmed"); } }); } } }); });

@alexmi1
Copy link

alexmi1 commented Nov 11, 2018

I'm not sure I'm understanding the issue well.
I made a test with a simple bot. I sent two different offers and then started the bot and it fired the newOffer event twice as expected.
It may be possible this is an issue that does not occur all the time, but then again from my understanding @Baterka claims it happens consistently even after restarting the bot.
Are you guys sure this is not just because of pollData? See here for more info https://github.com/DoctorMcKay/node-steam-tradeoffer-manager/wiki/Polling#poll-data

@raccoondays
Copy link

I did check the polling interval and tried changing it but it did not do anything when the offer wasn't coming through. However, it appears the issue is a combination of my hosting server being slow and Steam itself, not with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants