Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty placeholder causing active label #1737

Closed
wants to merge 2 commits into from
Closed

Empty placeholder causing active label #1737

wants to merge 2 commits into from

Conversation

drainx
Copy link
Contributor

@drainx drainx commented Jul 15, 2015

If the placeholder on an input is empty, we shouldn't classify that as active.

Signed-off-by: Daniel Rix Drainx1@live.com

drainx added 2 commits July 15, 2015 10:22
@drainx
If the placeholder on an input is empty, we shouldn't classify that a…
0f75bb5 
…s active.

Signed-off-by: Daniel Rix <Drainx1@live.com>
@drainx
Lets remove the active class when not in focus.
8972d96 
Signed-off-by Daniel Rix <Drainx1@live.com>
@Dogfalo
Copy link
Owner

Dogfalo commented Jul 16, 2015

Fixed by #1709. Nvm, I read that wrong.

@Dogfalo Dogfalo closed this Jul 16, 2015
@Dogfalo Dogfalo reopened this Jul 16, 2015
@revati
Copy link

revati commented Jan 9, 2016

Are there any updates with this issue?

@drainx
Copy link
Contributor Author

drainx commented Jan 9, 2016

I just outright abandoned using this project and moved to MDL.
Another reason I abandoned was because of how #1746 wan handled and the general idea of a broken master and a broken main site that maintainers kept refusing to fix.
This issue is just a testament to the maintainers that they don't care about the project anymore or they are more interesting in doing the work themselves as opposed to using PRs properly.
For more interesting things to read on how the maintainers don't care, look up #1791.

@tomscholz tomscholz closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drainx @Dogfalo @revati @tomscholz