Fixed navbar Mobile Collapse not giving correct example

[ghost]

The example on the NavBar page, at Mobile Collapse, doesn't give the right example. It's saying you need to add

<i class="material-icons">menu</i>

But it should be

<i class="mdi-navigation-menu"></i>

Like how it is on the SideNav page under JavaScript.

This commit fixed that.

[drainx]

I'll just reference #1746
I have given up on Materialize and have moved to MDL, since the devs working on MDL actually know what they are doing.

[ghost]

In regards to that PR you made, I'm actually going to make all those changes for the icons...

I'm closing this PR, in favor is a newer one.

[drainx]

I honestly wouldn't bother, because they will almost certainly give you the same reply they did me, and the PR will end up sitting for weeks, or just outright being rejected. Merging (no pun intended) all of the changes is rather useless, as others have tried to get them pulled and have been rejected.

In addition, the dev team here has outright refused to remove (and replace) dead demo links #1791 et al.

[ghost]

Fair enough.

[carlosperate]

The <i class="mdi-navigation-menu"></i> is the old icon system which is being phased out for the official google material icons, the ones using <i class="material-icons">menu</i>.

If there is any old documentation from the jade folder that is still using the old <i class="mdi-xxxx"></i> then a pull request will certainly be appreciated. If there are any problems using the new icons, then if you open an issue then the team can look into fixing those.

[ghost]

Those new icons aren't working indeed.

If what you're saying is true, then the documentation is ahead of the implementation. (Which is just as bad as the other way around)

[drainx]

@carlosperate As I pointed out in #1746 (and several others, this issue included,) the new implementation is broken.

There is no excuse for #1791 et al. though.

[carlosperate]

I'm not debating that there might be issues with the new icons, just that if anything is broken then it can be looked into and fixed, rather than revert back to the old implementation in the documentation.

About the specific icon issue you mentioned in your last comment from #1746, has 43d43c2 fixed that one? If not then we can open a new issue to capture that problem.

[ghost]

I'm updating the docs atm and I'll make a new PR for it.

[ghost]

@carlosperate See #1814

[ghost]

And about the buttons not working, please see this commit: https://github.com/TheSerenin/periodic-table/commit/3cf19df9df8fad62e0217cf936649f9358dea3a3