Impossible to validate the invoices with already paid amounts with 0% VAT

[rueBejo]

Hello,

Bug

Impossible to validate the invoices with already paid amounts from previous invoices as downpayments when a line has a 0% VAT.
Related to Bug #13333.

Environment

• Version: 11.0.4
• OS: Linux
• Web server: Apache
• PHP: 7.2
• Database: MySql
• URL(s): /compta/facture/card.php?facid=123&action=valid

Expected and actual behavior

Shall be able to apply downpayments and discounts already paid to the invoices. Everything is proceeding accordingly until the validation step where error message occurs :

Total of lines can't be negative for a given VAT rate.

Update 88d98ac solves this except in case of an account with 0% VAT.

Total of lines can't be negative for a given VAT rate : 0% rate shall be an exception in the checking loop.

Steps to reproduce the behaviour

• Edit a new proposal, accept it
• Make a new invoice from this proposal and choose account invoice with a 0% VAT rate
• Transform the account into a 'client remise'
• Make the final invoice from the proposal
• Apply the 'Remise'
• Validate the invoice : the error message appear and invoice stays in draft state

[eldy]

Can you provide a screenshot of content of invoice that show this trouble ? (if you can on demo.dolibarr.org)

[rueBejo]

Bonjour,

To reproduce this bug :

• make a commercial proposal
• make a deposit invoice ("acompte") from this commercial proposal with a 0% VAT rate. Flag this invoice as payed
• make a final invoice from the proposal and apply the discount from the deposit
• validate the invoice : error message will appear

See attached file.

I believe that an exception should be made for 0% rate in global VAT amount check.
Bug #13333 was fixed for others VAT rates, but still present for 0%.

Regards,

Bruno