fix sql error duplicate entry key on admin/boxes #14469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Aug 14, 2020
htdocs/admin/boxes.php
Outdated
| @@ -112,7 +112,7 @@ | |||
| } | |||
| else dol_print_error($db); | |||
|
|
|||
| $sql = "INSERT INTO ".MAIN_DB_PREFIX."boxes ("; | |||
| $sql = "INSERT IGNORE INTO ".MAIN_DB_PREFIX."boxes ("; | |||
There was a problem hiding this comment.
Does this work with pgsql ? Is this reserved word a sql standard reserved word or specific to mysql syntax ?
There was a problem hiding this comment.
after some research, it's not working on pgsql.
The other solution is to verify that the record does not exist before insert.
There was a problem hiding this comment.
@eldy B plan implemented ;)
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate entry error on boxe add
The user want to add boxes in home page from the admin/boxes.php screen.
If one user already had one of the added boxes it results with a duplicate entry error the prevent from adding the boxe.
Adding "IGNORE" to the insert request skip the insertion for already existing entries