FIX: In customer order when changing VAT for all items the change is not executed if VAT = 0% #16487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Feb 27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In customer order when changing VAT for all items it runs OK for any VAT except VAT= 0%. In that case the change is not executed.
The reason the updated is not executed is realted to an IF clause that evaluates the value of input "vatforalllines" that contains the numerical value for new VAT. When VAT is 0% this is interpreted as FALSE so the update is not fired.
There are 3 conditions on the mentioned IF clause:
$action == 'addline' && GETPOST('submitforalllines', 'alpha') && GETPOST('vatforalllines', 'alpha')
If fix #16485 (related to same portion of the code) is applied then "submitforalllines" would only exist when chaging VAT for all items and will allow to remove GETPOST('vatforalllines', 'alpha') from the IF clause.
FIX to #16486