Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: use account address in sepa mandate #23642

Conversation

thomas-Ngr
Copy link
Contributor

@thomas-Ngr thomas-Ngr commented Jan 20, 2023

NEW use account address in sepa mandate

In SEPA mandate pdf model, the account owner and address are the ones of the thirdparty.
However, users are allowed to define an owner and an address for the account, that are different from the name and address of the thirdparty.

This PR introduces option PRELEVEMENT_PREFER_ACCOUNT_OWNER_AND_ADDRESS that displays account owner + account address instead of thirdparty name + thirdparty address.

@eldy
Copy link
Member

eldy commented Jan 23, 2023

We don't need to add an option for this. Rules should be:
If we have a precise information on bank account, we must use this in priority. If not, we use a more generictm value of third party.
To fight against Options inflations, can you simplify the pr
this way (so remove the pafe setup of option)

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Jan 23, 2023
…>proprio because ->account_owner does not exist.
@thomas-Ngr thomas-Ngr force-pushed the develop_new_use_account_address_in_sepa_mandate branch from 4212cdb to 145a67d Compare February 3, 2023 08:51
@thomas-Ngr
Copy link
Contributor Author

@eldy I have removed the options.

@thomas-Ngr
Copy link
Contributor Author

@eldy could you have a look at the changes ?

@eldy eldy merged commit 4c266db into Dolibarr:develop Oct 16, 2023
eldy pushed a commit that referenced this pull request Oct 16, 2023
* NEW - Right for stats orders

* NEW: use account address in sepa mandate (#23642)

* New: allow to display account address in pdf sepa mandate. Fix: use ->proprio because ->account_owner does not exist.

* Stickler fix

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: thomas-Ngr <tnegre@open-dsi.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants