Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX error expedition qty 0 #24882

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

BenjaminFlr
Copy link
Contributor

@BenjaminFlr BenjaminFlr commented May 25, 2023

When SHIPMENT_GETS_ALL_ORDER_PRODUCTS is enabled, if we have a qty set to 0 (because already sent or unavailable in current stock), it generates an error on creating the shipment, as GETPOST($qty, 'int') doesn't get any value when the field is disabled, whereas GETPOSTINT generates an integer.

It's linked to the following error:

$this->error = 'ErrorMandatoryParametersNotProvided';

@eldy eldy merged commit b1038e3 into Dolibarr:16.0 May 25, 2023
@atm-maxime
Copy link
Member

@altairis-benjamin this needs an urgent FIX. You can't use GETPOSTINT to replace GETPOST($qty, 'int') or you loose any float value. For now users can't do a shipment with a decimal quantity. I am checking how to revert this and still fix your original issue

atm-maxime added a commit to atm-maxime/dolibarr that referenced this pull request Jun 23, 2023
atm-maxime added a commit to atm-maxime/dolibarr that referenced this pull request Jun 23, 2023
eldy added a commit that referenced this pull request Jun 23, 2023
FIX : decimal values were not possible on shipment quantities (introduced by #24882)
@BenjaminFlr BenjaminFlr deleted the fixNullQtyShipped branch June 27, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants