FIX Fatal Error PHP 8 : division by 0 #25384
Conversation
| $line_cost = $obj->min_price/$obj->qty * $sub_bom_line->qty * $line->qty; | ||
|
|
||
| if (!empty($obj->qty) && !empty($sub_bom_line->qty) && !empty($line->qty)) { | ||
| $line_cost = $obj->min_price/$obj->qty * $sub_bom_line->qty * $line->qty; |
There was a problem hiding this comment.
Don't you think we should, instead of just doing
line_cost = $obj->min_price
replace each qy with 1 if not defined. So we would get
$line_cost = $obj->min_price / (empty($obj->qty) ? 1 : $obj->qty) * (empty($sub_bom_line->qty) ? 1 : $sub_bom_line->qty) * (empty($line->qty) ? 1 : $line->qty);
Because a not defined qty means 1 i think ?
There was a problem hiding this comment.
What if a qty is defined as 0 (not quite sure if it's possible in this case) ?
But with the check on empty you will assume that his value is 1
There was a problem hiding this comment.
What if a qty is defined as 0 (not quite sure if it's possible in this case) ? But with the check on empty you will assume that his value is 1
On BOM, having a qty of 0 of a product should be same than not having the line at all. So this should not happen.
There was a problem hiding this comment.
I think it's important to allow to have a quantity of 0 for example for product for which we don't know the exact quantity we are going to use. We need to have it in the BOM but we don't know the qty so we can put 0 just to have the information that we need this product. Also it can be usefull for products (like consumables) we need only if something happens during the production, it's good to have it in the BOM so the operator can consume this product if needed.
There was a problem hiding this comment.
I think it's important to allow to have a quantity of 0 for example for product for which we don't know the exact quantity we are going to use. We need to have it in the BOM but we don't know the qty so we can put 0 just to have the information that we need this product. Also it can be usefull for products (like consumables) we need only if something happens during the production, it's good to have it in the BOM so the operator can consume this product if needed.
Good catch. Note that currently on v18, using a 0 qty is not possible. For your use case, we need to enter 1
Not also that you can add product on the fly during the production even if not present into the BOM.
eldy
added
the
Discussion
* FIX Fatal Error PHP 8 : division by 0 * Update objectline_view.tpl.php --------- Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr> Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FIX - database last_main_doc for user * Fix column display (#25490) * Fix php syntax (#25508) * FIX Fatal Error PHP 8 : division by 0 (#25384) * FIX Fatal Error PHP 8 : division by 0 * Update objectline_view.tpl.php --------- Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr> Co-authored-by: Laurent Destailleur <eldy@destailleur.fr> * Fix phpcs * FIX fatal error on Stripe setup page and security when terminal not used * FIX Try to fix the date of invoice on TakePOS on eastern timezone * FIX - database last_main_doc for user * Update objectline_view.tpl.php --------- Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr> Co-authored-by: John BOTELLA <john.botella@atm-consulting.fr> Co-authored-by: ptibogxiv <support@ptibogxiv.net> Co-authored-by: atm-lena <52402938+atm-lena@users.noreply.github.com> Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr> Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
FIX|Fix
Same fix of https://github.com/Dolibarr/dolibarr/pull/25373/files for v17