Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Fatal Error PHP 8 : division by 0 #25384

Merged
merged 2 commits into from
Jul 28, 2023
Merged

FIX Fatal Error PHP 8 : division by 0 #25384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f8fe8b
FIX Fatal Error PHP 8 : division by 0
Jul 18, 2023
c052678
Update objectline_view.tpl.php
eldy Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions htdocs/bom/tpl/objectline_view.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,11 @@
$resql_supplier_price = $object->db->query($sql_supplier_price);
if ($resql_supplier_price) {
$obj = $object->db->fetch_object($resql_supplier_price);
$line_cost = $obj->min_price/$obj->qty * $sub_bom_line->qty * $line->qty;

if (!empty($obj->qty) && !empty($sub_bom_line->qty) && !empty($line->qty)) {
$line_cost = $obj->min_price/$obj->qty * $sub_bom_line->qty * $line->qty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think we should, instead of just doing
line_cost = $obj->min_price
replace each qy with 1 if not defined. So we would get
$line_cost = $obj->min_price / (empty($obj->qty) ? 1 : $obj->qty) * (empty($sub_bom_line->qty) ? 1 : $sub_bom_line->qty) * (empty($line->qty) ? 1 : $line->qty);
Because a not defined qty means 1 i think ?

Copy link
Contributor

@hansemschnokeloch hansemschnokeloch Jul 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a qty is defined as 0 (not quite sure if it's possible in this case) ?
But with the check on empty you will assume that his value is 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a qty is defined as 0 (not quite sure if it's possible in this case) ? But with the check on empty you will assume that his value is 1

On BOM, having a qty of 0 of a product should be same than not having the line at all. So this should not happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to allow to have a quantity of 0 for example for product for which we don't know the exact quantity we are going to use. We need to have it in the BOM but we don't know the qty so we can put 0 just to have the information that we need this product. Also it can be usefull for products (like consumables) we need only if something happens during the production, it's good to have it in the BOM so the operator can consume this product if needed.

Copy link
Member

@eldy eldy Jul 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to allow to have a quantity of 0 for example for product for which we don't know the exact quantity we are going to use. We need to have it in the BOM but we don't know the qty so we can put 0 just to have the information that we need this product. Also it can be usefull for products (like consumables) we need only if something happens during the production, it's good to have it in the BOM so the operator can consume this product if needed.

Good catch. Note that currently on v18, using a 0 qty is not possible. For your use case, we need to enter 1
Not also that you can add product on the fly during the production even if not present into the BOM.

} else {
$line_cost = $obj->min_price;
}
print '<td class="linecolcost nowrap right" id="sub_bom_cost_'.$sub_bom_line->id.'"><span class="amount">'.price2num($line_cost, 'MT').'</span></td>';
$total_cost+= $line_cost;
}
Expand Down