FIX: Update mouvementstock.class.php #25396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If first character change to upper case, some external modules don't show its origin in mouvements.
eldy
reviewed
Jul 23, 2023
| @@ -975,7 +975,7 @@ public function get_origin($origin_id, $origin_type) | |||
| if ($origin_type) { | |||
| // Separate originetype with "@" : left part is class name, right part is module name | |||
| $origin_type_array = explode('@', $origin_type); | |||
| $classname = ucfirst($origin_type_array[0]); | |||
| $classname = $origin_type_array[0]; | |||
There was a problem hiding this comment.
Class name should start with uppercase.
Contact, Warehouse, User, ...
This may generates a lot of trouble if classname is only contact, warehouse, user...
There was a problem hiding this comment.
All right I agree, but uppercase is already done on line 982...
Module name and URL use to be in lowercase , which is the problem I wanted to correct.
I propose a new commint more simple
eldy
added
the
PR to fix - See feedback in comments
More elegant. We don't need to change to upper case (line 978) and then to lower case (line 980). It is only necessary when creating a new class (line 983) The module name and url are in lower case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If first character changes to upper case, some external modules don't show its origin in mouvements.