FIX #25853 Thirdparty Massaction #25868
Conversation
| // if (isset($this->total_localtax1)) $this->total_localtax1=trim($this->total_localtax1); | ||
| // if (isset($this->total_localtax2)) $this->total_localtax2=trim($this->total_localtax2); | ||
| if (isset($this->total_localtax1)) { | ||
| $this->total_localtax1=trim($this->total_localtax1); |
There was a problem hiding this comment.
Welcome back juanjo !
We should not use trim here, because total_localtax1 should be a float here when calling the method. And trim is designed for string. May be you want to do this ?
if (empty($this->total_localtax1)) {
$this->total_localtax1 = 0;
}
There was a problem hiding this comment.
Thank you Laurent for the welcome,
Ok, I had only uncommented the lines, now changed by empty check and make and also done for total_ttc
eldy
added
the
Discussion
# Conflicts: # htdocs/core/lib/functions.lib.php
| if (empty($this->total_localtax2)) { | ||
| $this->total_localtax2 = 0; | ||
| } | ||
| if (empty($this->total_ttc)) { |
There was a problem hiding this comment.
@eldy @simnandez
On develop you have "if (isset($this->total_ttc)) {" and maybe it not needeed for yout fix (can occur conflicts with develop branch)
There was a problem hiding this comment.
Yes, solution is to edit the suggestion to restore code for this line as it is done in v20 so this should avoid any conflict and has same effect than the suggested code.
So we can validate the PR just after.
Done.
|
same point as lvessiller |
No description provided.