NEW resource improvements - data structure #26285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c17d144.
eldy
reviewed
Oct 20, 2023
| ALTER TABLE llx_resource ADD COLUMN zip varchar(25) DEFAULT NULL AFTER address; | ||
| ALTER TABLE llx_resource ADD COLUMN town varchar(50) DEFAULT NULL AFTER zip; | ||
| ALTER TABLE llx_resource ADD COLUMN photo_filename varchar(255) DEFAULT NULL AFTER town; | ||
| ALTER TABLE llx_resource ADD COLUMN user_places integer DEFAULT NULL AFTER photo_filename; |
There was a problem hiding this comment.
Whatvis user_places field. Can you provide example of valus ?
There was a problem hiding this comment.
Whatvis user_places field. Can you provide example of valus ?
A resource could be various things : room, venue, vehicle, tool, machine, etc, so it must remain generic.
However a resource in many cases will be used by a human, examples :
- Room: maximum number of people it can sit: 50
- Venue: maximum number of people it can hold: 250
- Vehicle: number of seats: 5
- Tool: number of simultaneous users: 1
- Machine: number of operators: 3
In some cases a resource might not have any human users or this field is not important, in that case the value would be 0 or NULL.
Maybe the name of this field could be something else like user_seats, max_users or max_places
There was a problem hiding this comment.
So i suggest "max_users" width a default NULL
eldy
added
the
Discussion
This was referenced Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW Resource improvements - data structure
SQL part of #26230