FIX - Repair the replenishment list

[atm-lucasmantegari]

FIX - Repair the replenishment list

Repair the replenishment list which was not sorted correctly with the warehouses

[atm-lucasmantegari]

@eldy

I solved the problem this way, is this the best solution?

$list_warehouse_selected = ($fk_entrepot < 0) ? '0' : $fk_entrepot;

$sql .= ' FROM ' . MAIN_DB_PREFIX . 'product as p';
$sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'product_stock as s ON p.rowid = s.fk_product';
if ($list_warehouse_selected == 0) {
	$list_warehouse = (empty($listofqualifiedwarehousesid) ? '0' : $listofqualifiedwarehousesid);
	$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse) . ')';
} else {
	$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse_selected) . ')';
}

[eldy]

The $listofqualifiedwarehousesid is a security protection. It is list of warehouse allowed according to the multicompany we are connected to.
So the test on it must ALWAYS be present. With your suggested change if a filter is set, you can bypass the security filter.
Then if there is a custom filter, the filter must be added.

[atm-lucasmantegari]

@eldy

With these modifications everything is good and works correctly while maintaining the security test on the entity's warehouses.

$list_warehouse = (empty($listofqualifiedwarehousesid) ? '0' : $listofqualifiedwarehousesid);

$sql .= ' FROM ' . MAIN_DB_PREFIX . 'product as p';
$sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'product_stock as s ON p.rowid = s.fk_product';
$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse) . ')';

$list_warehouse_selected = ($fk_entrepot < 0) ? '0' : $fk_entrepot;
$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse_selected) . ')';

[eldy]

@eldy

With these modifications everything is good and works correctly while maintaining the security test on the entity's warehouses.

$list_warehouse = (empty($listofqualifiedwarehousesid) ? '0' : $listofqualifiedwarehousesid);

$sql .= ' FROM ' . MAIN_DB_PREFIX . 'product as p';
$sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'product_stock as s ON p.rowid = s.fk_product';
$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse) . ')';

$list_warehouse_selected = ($fk_entrepot < 0) ? '0' : $fk_entrepot;
$sql .= ' AND s.fk_entrepot  IN (' . $db->sanitize($list_warehouse_selected) . ')';

Looks better. Can you confirm that when product_stock is empty for product or just into non zllowed or not the filtered watehouse, the line of product is returned (but qty will be viewed as 0)

[atm-lucasmantegari]

@eldy

Yes I confirm this, however the sorting on the selected warehouse only happens when the pse.desiredstock is >0