Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fatal error on create loan schedule #30656

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Conversation

lippoliv
Copy link
Contributor

Instructions

This is a template to help you make good pull requests. You may use Github Markdown syntax to format your issue report.
Please:

  • only keep the "FIX", "CLOSE", "NEW", "PERF" or "QUAL" section (use uppercase to have the PR appears into the ChangeLog, lowercase will not appears)
  • follow the project contributing guidelines
  • replace the bracket enclosed texts with meaningful information

FIX|Fix #30655

When handling errors of \LoanSchedule::create the view broke with a fatal php error.

  1. Accessing old variable
  2. Setting lines property to NULL instead of an empty array, as expected later

I fixed that and I set a more speaking, but still hardcoded error message in this case (it was "step1"). This probably should be discussed.

@lippoliv
Copy link
Contributor Author

fyi: I forgot my local git config, so my commits are unverified. Let me know if this is a problem, then I create a new PR with "fully" verified commits ;)

@eldy eldy merged commit 9757e18 into Dolibarr:19.0 Aug 16, 2024
3 of 4 checks passed
@lippoliv lippoliv deleted the bug/30655 branch August 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants