FIX : attached file on first page load #30694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Aug 23, 2024
htdocs/ticket/card.php
Outdated
| @@ -738,7 +738,21 @@ | |||
|
|
|||
| if ($action == 'create' || $action == 'presend') { | |||
| $formticket = new FormTicket($db); | |||
| if (!GETPOSTISSET('token')) { | |||
There was a problem hiding this comment.
In other part of code, we used a different solution:
The parameter mode=init was added on the link with action=presend
And we reset dir and session when mode=init. For eample in htdocs/admin/mails.php
// Init list of files
if (GETPOST("mode", "aZ09") == 'init') {
$formmail->clear_attached_files();
}
When mode is not init, we untouch dir
Can you try to use a similar method for better code consistency ?
There was a problem hiding this comment.
I have taken your comment into account to use mode=init as suggested. This results in a modification of modTiket and an SQL update. Let me know if this works for you.
eldy
added
the
Discussion
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
When creating a new ticket, if the user adds an attachment without creating the ticket, leaves the page, and then returns to the ticket creation page, the previously added attachment is still present. This behavior is undesirable as it can lead to confusion for the user and potentially result in the addition of irrelevant attachments to a new ticket.
Proposed Solution
To resolve this issue, we will check if the page is loaded for the first time by testing for the presence of a token in the $_POST. If this is the case, we will clean up the temporary attachments associated with the user's session.