Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX issue on action set condition in particular when you set a deposi… #31518

Conversation

atm-corentin
Copy link
Contributor

FIX|Fix # Change payment term from deposit to an other payment term

When creating a commercial proposal and setting an advance payment condition, and then wanting to change to a condition such as payment upon receipt, the item along with the proposal still displays the amount of the initial advance next to the new payment condition. Moreover, it was not set to zero during this change.
I have therefore modified it so that if the payment condition is an advance, it retains the current default behavior. However, if the payment method was initially set to an advance on the commercial proposal and then changed to another payment condition, the deposit percentage value is updated in the database so that it is not considered in the commercial proposal.

@eldy eldy merged commit c48b035 into Dolibarr:18.0 Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants