Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webserver #451

Closed
DonJayamanne opened this issue Feb 22, 2020 · 5 comments · Fixed by #469
Closed

Remove webserver #451

DonJayamanne opened this issue Feb 22, 2020 · 5 comments · Fixed by #469
Assignees

Comments

@DonJayamanne
Copy link
Owner

I would like to get rid of express and the like.
Making this simpler & lightweight.

@ole1986
Copy link
Contributor

ole1986 commented Feb 22, 2020

I actually did not knew that getting rid of express would be an option.

I do have a websocket server implementation in my local test branches which still uses express (expressWs).

So how we are going to fetch the data from?

@DonJayamanne
Copy link
Owner Author

So how we are going to fetch the data from?

VSC has an API to send requests back to the extension. See here https://code.visualstudio.com/api/extension-guides/webview#passing-messages-from-an-extension-to-a-webview

@DonJayamanne
Copy link
Owner Author

local test branches which still uses express (expressWs).

We can keep it for testing purposes. I find this useful for react, as I can then use chrome extensions to analyze what's going on in react world.
However for production I think we must get rid of it, it will be faster (slightly) - smaller bundle and monkeying around with ports and the like.

@ole1986
Copy link
Contributor

ole1986 commented Feb 22, 2020

Ah... postMessages!

So PR #440 may already become a more postMessage related change instead of using websocket and express

I would love to take over that part

@DonJayamanne
Copy link
Owner Author

I would love to take over that part

Go for it. Please feel free to take any task. I'm merely adding a list of things that I think needs to be done. It doesn't have to be me.

I'd get rid of all of the express, etc stuff..
Again thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants