Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are converted to all black after compression on IPad pro #222

Open
Russell-Pollari opened this issue Aug 28, 2024 · 1 comment
Open

Comments

@Russell-Pollari
Copy link

No errors thrown, but image is uploaded as a black square.

I think the root cause is that the user agent string on an iPad pro presents as a Mac.

Since the user agent determines the browser and the max canvas size, this would mean that the library is assuming the wrong maximum canvas size for the Ipad.

I don't have an IPad pro myself to test on, this was reported by a customer. Will continue to do some debugging and update it here.

If you have an iPad pro and can share what the user agent is, that would be very helpful!

@Russell-Pollari
Copy link
Author

Yes I think the solution will require other means of browser/device detection that does not depend on the user agent..

more context: https://stackoverflow.com/questions/57776001/how-to-detect-ipad-pro-as-ipad-using-javascript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant