Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor defaults, for example empty spool weight #307

Closed
sprior opened this issue Feb 8, 2024 · 7 comments
Closed

Add vendor defaults, for example empty spool weight #307

sprior opened this issue Feb 8, 2024 · 7 comments
Labels
Feature Request New feature or request

Comments

@sprior
Copy link

sprior commented Feb 8, 2024

Is your feature request related to a problem? Please describe.
Currently every time you enter a new filament you have to fill in fields like empty spool weight with no default value

Describe the solution you'd like
Vendors appear to change empty spool vendors rarely (though it does happen). If you added a field to the Vendor record "current empty spool weight" and use that as a default in the create filament screen once the vendor has been selected you would save data entry time. When the vendor changes their spools a user would change that in the vendor screen and from that time on new filaments would default to the new value.

Describe alternatives you've considered
You could start to capture all the spool possibilities for a vendor, but that's probably overkill for 90% of cases.

@sprior sprior added the Feature Request New feature or request label Feb 8, 2024
@Donkie
Copy link
Owner

Donkie commented Mar 2, 2024

Doesn't vendors have different spools for their different in-house brands? I think having this be default per vendor is too specific and would rarely be correct.
It's better to focus on having a filament database with known spool values instead.

@sprior
Copy link
Author

sprior commented Mar 2, 2024

Every spool I ever bought from Hatchbox (no matter what the color or type of plastic) was the same, Esun as well. When I say vendor I'm talking about the in-house brand so even if it did vary by brand it would still make sense to me to have a default spool weight associated with that brand. It may be true that some really low end brands might use whatever empty spools they got cheap that month, but I don't think that's the norm.

@BigTrikerTom
Copy link

You could also define the empty coils as an independent area.
This would also allow you to store different coils for each manufacturer. Some manufacturers offer plastic, cardboard, refill and/or wooden spools. In addition, you wouldn't have to search the Internet or your own tables every time for the empty weight of the respective spool.

Just my 2 cents...

@spyder007
Copy link
Contributor

Right now there is an empty spool weight at the filament level, which gives you the ability to set those weights per filament. This should allow you to account for individual differences.

If there was an 'empty spool weight' at the vendor level that "fell through" to the filament, that would be ideal. It's essentially a "default" value for empty spool weight that is applied when you create a new filament.

I would contend, though, that the Filament shouldn't have ANY spool values on it: that's what Spool is for. I've created a discussion (#338) to see if this would be a desirable change, or if I am just crazy.

@runtpacket
Copy link

Doesn't vendors have different spools for their different in-house brands? I think having this be default per vendor is too specific and would rarely be correct. It's better to focus on having a filament database with known spool values instead.

I have been thinking about this lately. Could we setup a way to pull the filaments from a community ran db? Make it optional so you can either use local db or community driven one.

@Donkie
Copy link
Owner

Donkie commented May 19, 2024

Already in progress :) https://github.com/Donkie/SpoolmanDB
Will be available in next release

@spyder007
Copy link
Contributor

This issue can probably be closed, considering #339 was release in 0.17 and the community DB support is in 0.18

@Donkie Donkie closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants