Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Add (SDS) Safety Data Sheet & Technical Data Sheet #395

Open
TexZeTech opened this issue Jun 3, 2024 · 2 comments
Open
Labels
Feature Request New feature or request

Comments

@TexZeTech
Copy link

I would like the integration of Safety Data Sheet(s) & Technical Data Sheet(s) with links to original source(s).

Describe the solution you'd like
A way to easily upload files to a location (eg; to a network share or docker container) and to display this information when looking for it into another window eg; if its a pdf or text file to then open it in a new tab or internal window.

Describe alternatives you've considered
Manually adding pdfs/text/jpgs to network share or the like and linking to those from the spoolman DB.

@TexZeTech TexZeTech added the Feature Request New feature or request label Jun 3, 2024
@Donkie
Copy link
Owner

Donkie commented Jun 6, 2024

You can already do this using the Extra Fields feature. Upload them to a location of your choice and then add them as links to your own custom field.

I don't want to add any file hosting capabilities to Spoolman since that is a whole can of worms of security related issues.

@TexZeTech
Copy link
Author

You can already do this using the Extra Fields feature. Upload them to a location of your choice and then add them as links to your own custom field.

This is why I stated what I've considered, but I clearly didn't convey that correctly.

I don't want to add any file hosting capabilities to Spoolman since that is a whole can of worms of security related issues.

I guess I don't fully appreciate what security issues could arise from uploading to an internal docker named volume linked to Spoolman for secondary file storage.

I just don't think it would be that large of an issue at least no less then someone trying to break the docker container using something like SQL privilege escalation or any other method of attack, however I will be the first to admit I don't code for a living.

What I would like is to simply reference a named volume that is linked up with Spoolman where I can pass a file over to that volume using your interface in a convent way for filament referencing.

If I have Manufactures -> Filaments -> Spools eg; Prusa3d -> PETG -> Prusa3d - Ultramarine Blue Transparent then I pass the file to the folder path that is generated to match where ever the SDS / Data Sheet are added. So if I attach the SDS to the Filament it would show up /ID#/ID#/sds.pfd eg; /3/9/sds.pdf or something human readable.

This could also just generate the folder path for the location in question and the user has to use ftp (or other method) to add the file manually this is less ideal though.

In either case at the minimum I would like a window that displays similar function to https://www.w3docs.com/snippets/html/how-to-embed-pdf-in-html.html like when you open the QR Code Scanner window.

Again thank you for the great application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants