Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local cache for helm charts #166

Closed
yorik opened this issue Aug 9, 2024 · 1 comment · Fixed by #171
Closed

Local cache for helm charts #166

yorik opened this issue Aug 9, 2024 · 1 comment · Fixed by #171

Comments

@yorik
Copy link
Contributor

yorik commented Aug 9, 2024

I'm trying to use flux-build for not a big gitops repo, but it downloads ~30 helm charts 4000 times! This overloads our registry and slows down rendering a lot.

I've seen that there are commented out attempts to add cache, also there are different caching in helm packages. I could contribute, but would appreciate some hints how to do it better.

Thanks!

@raffis
Copy link
Member

raffis commented Aug 9, 2024

This part is mostly from upstream and was disabled in this initial version. I do agree that we need a caching layer here thats why it was left commented in the code.
Happy to merge a pr regarding this! Likely to be extended in https://github.com/DoodleScheduling/flux-build/blob/master/internal/build/helm.go#L464

You might also check upstream flux source-controller base regarding that bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants