Move extension to Page

Add rules to YML to try and be last in line Add checking on existing tags to attempt to remove existing canonical tags
DorsetDigital · Jun 20, 2018 · 25aadd4 · 25aadd4
1 parent a965361
commit 25aadd4
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 20 deletions.
diff --git a/_config/config.yml b/_config/config.yml
@@ -1,7 +1,9 @@
 ---
 Name: 'dd-canonical'
+After:
+  - '*'
 ---
-SilverStripe\CMS\Model\SiteTree:
+Page:
   extensions:
     - DorsetDigital\SilverStripeCanonical\SiteTreeCanonicalExtension
 

diff --git a/src/SiteTreeCanonicalExtension.php b/src/SiteTreeCanonicalExtension.php
@@ -8,23 +8,37 @@
 class SiteTreeCanonicalExtension extends SiteTreeExtension
 {
 
-    public function MetaTags(&$tags)
-    {
-
-        $siteConfig = SiteConfig::current_site_config();
-        if ($siteConfig->CanonicalDomain != '') {
-            $canonicalBase = trim($siteConfig->CanonicalDomain, '/');
-            if (method_exists($this->owner, 'CanonicalLink')) {
-                $link = $this->owner->CanonicalLink();
-            } else {
-                $link = $this->owner->Link();
-            }
-            $canonLink = $canonicalBase . $link;
-            $atts = [
-                'rel' => 'canonical',
-                'href' => $canonLink
-            ];
-            $tags .= "\n" . HTML::createTag('link', $atts) . "\n";
-        }
-    }
+ public function MetaTags(&$tags)
+ {
+
+  $siteConfig = SiteConfig::current_site_config();
+  if ($siteConfig->CanonicalDomain != '') {
+   $canonicalBase = trim($siteConfig->CanonicalDomain, '/');
+   if (method_exists($this->owner, 'CanonicalLink')) {
+    $link = $this->owner->CanonicalLink();
+   } else {
+    $link = $this->owner->Link();
+   }
+   $canonLink = $canonicalBase . $link;
+   $atts = [
+       'rel' => 'canonical',
+       'href' => $canonLink
+   ];
+   $canonTag = HTML::createTag('link', $atts);
+
+   $tagsArray = explode(PHP_EOL, $tags);
+   $tagPattern = 'rel="canonical"';
+
+   $tagSearch = function ( $val ) use ( $tagPattern ) {
+    return ( stripos($val, $tagPattern) !== false ? true : false );
+   };
+
+   $currentTags = array_filter($tagsArray, $tagSearch);
+   $cleanedTags = array_diff($tagsArray, $currentTags);
+
+   $cleanedTags[] = $canonTag;
+
+   $tags = implode(PHP_EOL, $cleanedTags);
+  }
+ }
 }