NewtonSoft.JSon should not be added as "analyzer"

[jessehouwing]

Recent upgrade has added NewtonSoft.JSon as an analyzer package, yet newtonsoft doesn't provide any analyzers.

 + <Analyzer Include="..\packages\StyleCop.Analyzers.1.0.0-beta013\analyzers\dotnet\cs\Newtonsoft.Json.dll" />
 + <Analyzer Include="..\packages\StyleCop.Analyzers.1.0.0-beta013\analyzers\dotnet\cs\StyleCop.Analyzers.dll" />

I suppose that this reference should not have been added at all and that the assembly should live in a tools folder of the nuget package instead.

[sharwell]

This reference is required because our analyzers in StyleCop.Analyzers.dll use it during analysis. If the assembly is not listed as an analyzer, it will not be located during the build and any analyzer which attempts to use it will throw an exception. Marking as a duplicate of #1624.

[jessehouwing]

It would be better if you were to use the same version of NewtonSoft JSon that ships with Visual Studio... Plus, it now forces all analyzers that depend on this assembly to use at least your version. Wouldn't statically registering an AppDomain.AssemblyResolve event allow you to fetch the assembly either from the same directory the main assembly is stored, or a tools assembly folder?!

[jessehouwing]

This should do the trick: http://blogs.msdn.com/b/microsoft_press/archive/2010/02/03/jeffrey-richter-excerpt-2-from-clr-via-c-third-edition.aspx

[sharwell]

➡️ I reopened issue #1624 for further discussion.