Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergonomics question #18

Open
StevenLangbroek opened this issue Feb 10, 2019 · 0 comments
Open

Ergonomics question #18

StevenLangbroek opened this issue Feb 10, 2019 · 0 comments

Comments

@StevenLangbroek
Copy link

StevenLangbroek commented Feb 10, 2019

I have a DX question: should people import from immutable-ext, or use it as a "polyfill" sort of?

index:

import 'immutable-ext';

import Application from './Application';

Application.start();

Application:

import Task from 'folktale/concurrency/task';
import { Map } from 'immutable';

Map({ thing: 'value' }).traverse(Task.of, x => Http.get(x))

Given the wide range of experience and variable value this adds based on what people work on (not everybody uses immutablejs to the same extent in our applications), I feel like asking everybody to import List and Map from immutable-ext, but the rest from immutablejs might annoying to ask, and one of those nits during code review that are going to make me extremely disliked :D. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant