Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Protobuf.jl versions 1.0 and up #84

Closed
lambe opened this issue Oct 16, 2023 · 3 comments
Closed

Support Protobuf.jl versions 1.0 and up #84

lambe opened this issue Oct 16, 2023 · 3 comments

Comments

@lambe
Copy link

lambe commented Oct 16, 2023

I'm using this package to save ONNX-format models alongside some work that uses PProf for profiling my code. PProf currently uses a recent version of Protobuf.jl so I can't have both packages installed at the same time because of the dependency conflict. I'm currently working around that issue by only installing this package when I want to save an ML model in ONNX format and then uninstalling when I'm done, but that could be improved.

Are there any plans to upgrade to version 1 of Protobuf.jl and up?

I've played around with a solution and I'm happy to share my own work-in-progress if you're interested - it looks like some restructuring of the serialize and deserialize code is in order.

@DrChainsaw
Copy link
Owner

We should definitely update Protobuf.jl. I just kinda forgot about it.

If you have a work in progress then feel free to submit a PR. Does the restructuring of the serialize/deserialize code follow from Protobuf 1.0 or is it separate?

@lambe
Copy link
Author

lambe commented Oct 16, 2023

See #85

So far, I generated new Julia code from the ONNX protobufs and updated some of the other files so that precompilation works. Unit tests are still broken and I'm not quite sure how to fix them - an extra set of eyes would be helpful.

@DrChainsaw
Copy link
Owner

Closed by #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants