Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly drop the check for "is configuration changed" #13

Open
GitMensch opened this issue Jan 10, 2021 · 0 comments
Open

Possibly drop the check for "is configuration changed" #13

GitMensch opened this issue Jan 10, 2021 · 0 comments
Assignees

Comments

@GitMensch
Copy link
Collaborator

As far as I see this function is only triggered by vscode and it is only triggered if a setting actually did change.

Is this the case? If yes then I'd remove the check from

// bail out if nothing changed

Primary reason: if more than one person adds/changes settings in the same time we'll get to merge conflicts (easy to solve but still) but most important: I think that's a possible braking part (if someone forgets to adds a setting) and especially: doesn't seems to be necessary (says the vscode-extension-noob).

Opinions? Insights?
OK for delete?

@GitMensch GitMensch assigned DrMerfy and GitMensch and unassigned DrMerfy Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants