-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow Final match to be a draw #160
Comments
Hey! Sorry for the delay.
The lib is actually ignoring the
That's weird because with my snippet, the lib throws a "Participant not found." error, since the final match doesn't have a winner. I'll add a better error message for this.
I won't even try to evaluate the difficulty for this, because I simply won't let this happen and won't accept a PR for it, I'm sorry. This is more than an "edge case": it's an invalid case in this format of tournament.
The only update I would be willing to do to the lib is to throw an error message when trying to set a As you said this is an edge case for you, I'll let you support this on your side. If you really want to display this case with the viewer, I suggest you override the result with (This works because the viewer doesn't have any "tournament logic", it will simply display what you give to it.) |
Thank you as always for your detailed responses! I fully understand your decision to not support this scenario. I agree it's super edge case. Will figure out what to do with it when/if it happens. Thanks! |
Although it's definitely an edge case, we are seeing the possibility of a final match in an elimination tournament to have a no-show on both participants. After some thought, we figure that the best resolution in this case, would be for them both to share the 1st place.
The match would of course would have no winners, so I tried setting the match as a draw. Good news is that it allowed me to do it.
Bad news is that the Brackets UI is not showing the match as finished. It's still showing it with the default dashes:
Second bad news is that when I try to get the final standings, for some reason it's just removing one of the final participants from the rank:
You can reference the above image as well for the full list of participants. It removed the
Ayrious2
participant.Would it be too hard to allow for this scenario to happen? And if you don't have the time to support it, do you mind sharing some pointers on what would need to be changed and I can try to make a PR myself?
Thanks!
The text was updated successfully, but these errors were encountered: