Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keybinds which include a modifier key, or multiple keybinds per action. #156

Open
seisatsu opened this issue May 18, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@seisatsu
Copy link
Member

seisatsu commented May 18, 2017

For example, allow us to bind SHIFT + OTHER KEY to do an action. This will also let us rebind the Quit keybind which is currently hard-coded. As an aside, we should probably make the pause key not hard-coded at the same time.

This will involve allowing a keybind value such as "SDLK_LSHIFT+SDLK_UP", as well as making keybind values lists of strings instead of just strings.

@seisatsu seisatsu added this to the Alpha-future milestone May 18, 2017
@seisatsu seisatsu self-assigned this May 18, 2017
@seisatsu seisatsu changed the title Support keybinds which include a modifier key. Support keybinds which include a modifier key, or multiple keybinds per action. May 18, 2017
@pmer
Copy link
Member

pmer commented May 22, 2017

What does it mean for an action to have multiple keybinds?

@seisatsu
Copy link
Member Author

For example, left shift and right shift could both activate the same action.

@seisatsu seisatsu modified the milestones: Alpha-future, Alpha-0.0.9 Sep 21, 2017
@pmer
Copy link
Member

pmer commented Sep 21, 2017

If we expose the fact that we're using SDL to game authors then it'll cause trouble if we ever switch away from SDL in the future.

For instance, we might like to allow authors to say "LSHIFT+UP" instead of the SDL-specific "SDLK_LSHIFT+SDLK_UP".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants