Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposure of personal data #10

Closed
tobbexiv opened this issue Jan 11, 2017 · 4 comments
Closed

Exposure of personal data #10

tobbexiv opened this issue Jan 11, 2017 · 4 comments

Comments

@tobbexiv
Copy link
Contributor

Personal data like email, registration date, last login, structure of admin menu, role ids, ... is present in the listing json in the page view. For privacy reasons this should not be the case.

Suggestion: Either remove line ListingsModule.php#L34 completely (best option in my opinion) or change it to

            ->related(['editor' => function($query) {
                return $query
                    ->select('id', 'username');
            }])

Then there is still the keys available, but at least the data ist not presented to everybody.

Also consider if all data which is returned by the other entities is really necessary and adjust the jsonSerialize function if possible.

@luisreyes
Copy link
Contributor

Ah yes! Incomplete functionality. It'll be cleaned up on the next release. Thanks.

@luisreyes
Copy link
Contributor

Resolve in commit 133cd09.
Version is now 1.0.5

@tobbexiv
Copy link
Contributor Author

To me it seems that you fixed the issue in the admin panel, but missed the frontend. The line linked above is still unchanged and I can access the personal data in the frontend after updating. So please re-open this issue.

@luisreyes
Copy link
Contributor

Your correct. Thanks for pointing it out. This was very deep and overlooked.

@luisreyes luisreyes reopened this Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants