-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposure of personal data #10
Comments
Ah yes! Incomplete functionality. It'll be cleaned up on the next release. Thanks. |
Resolve in commit 133cd09. |
To me it seems that you fixed the issue in the admin panel, but missed the frontend. The line linked above is still unchanged and I can access the personal data in the frontend after updating. So please re-open this issue. |
Your correct. Thanks for pointing it out. This was very deep and overlooked. |
Personal data like email, registration date, last login, structure of admin menu, role ids, ... is present in the listing json in the page view. For privacy reasons this should not be the case.
Suggestion: Either remove line ListingsModule.php#L34 completely (best option in my opinion) or change it to
Then there is still the keys available, but at least the data ist not presented to everybody.
Also consider if all data which is returned by the other entities is really necessary and adjust the
jsonSerialize
function if possible.The text was updated successfully, but these errors were encountered: