Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Beacon.h' file not found #19

Closed
steveliles opened this issue Feb 1, 2024 · 5 comments · Fixed by #20
Closed

'Beacon.h' file not found #19

steveliles opened this issue Feb 1, 2024 · 5 comments · Fixed by #20

Comments

@steveliles
Copy link

From a clean initial install into an expo project (expo 50), when I try to build for ios i get:

 1 | #import "HelpscoutBeacon.h"
> 2 | #import "Beacon.h"
    |         ^ 'Beacon.h' file not found
  3 | #import <React/RCTBridgeModule.h>
  4 | 
  5 | @implementation HelpscoutBeacon

@nitrique's branch https://github.com/nitrique/react-native-helpscout-beacon/tree/master seems to work (at least it builds, have not yet confirmed that the beacon works).

@nitrique
Copy link

nitrique commented Feb 1, 2024

Hey @steveliles, Yes it's in production on our side :)
Our PR is still in pending state :|

@steveliles
Copy link
Author

@nitrique lifesaver 💥

@steveliles
Copy link
Author

@nitrique have you published your fork to public npm at all? using the github url in npm package does not work because tsc does not get executed ... i can run locally by linking to the local clone where i have run tsc, but this isn't gonna work on EAS build ... (if not i will fork and publish myself)

@nitrique
Copy link

nitrique commented Feb 1, 2024

@steveliles,

I have detached the fork from this repository to evolve further more the package as suggested by github documentation, obviously it closed the PR on this repo.

NPM package has been published in https://www.npmjs.com/package/@nitrique/react-native-helpscout-beacon

Release is v0.5.3

JS assets has been included in the release.

Feel free to contribute to the repo, any PR are welcome :)

@steveliles
Copy link
Author

@nitrique legend! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants